<html>
<head><meta charset="utf-8"><title>do_docs_comments · t-compiler/rust-analyzer · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/index.html">t-compiler/rust-analyzer</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/do_docs_comments.html">do_docs_comments</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="187055459"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/do_docs_comments/near/187055459" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> divma <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/do_docs_comments.html#187055459">(Jan 31 2020 at 04:09)</a>:</h4>
<p>Could someone elaborate on the purpose of <a href="https://github.com/rust-analyzer/rust-analyzer/blob/e48033d066b26cb9e85c94cf47e6b8e388176e0a/xtask/tests/tidy-tests/docs.rs#L32-L105" target="_blank" title="https://github.com/rust-analyzer/rust-analyzer/blob/e48033d066b26cb9e85c94cf47e6b8e388176e0a/xtask/tests/tidy-tests/docs.rs#L32-L105">this test</a>? <br>
It's failing with:  thread 'docs::no_docs_comments' panicked at 'called <code>Result::unwrap()</code> on an <code>Err</code> value: Custom { kind: InvalidData, error: "stream did not contain valid UTF-8" }',<br>
Specifically, it's failing <a href="https://github.com/rust-analyzer/rust-analyzer/blob/e48033d066b26cb9e85c94cf47e6b8e388176e0a/xtask/tests/tidy-tests/docs.rs#L53" target="_blank" title="https://github.com/rust-analyzer/rust-analyzer/blob/e48033d066b26cb9e85c94cf47e6b8e388176e0a/xtask/tests/tidy-tests/docs.rs#L53">here</a></p>



<a name="187056064"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/do_docs_comments/near/187056064" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> divma <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/do_docs_comments.html#187056064">(Jan 31 2020 at 04:28)</a>:</h4>
<p>ok found it... Is some point I had <code>cargo build</code> (or something) inside a crate, so there was a <code>target</code> dir there. Shouldn't the test ignore all <code>target</code> dirs? I mean, I know this one is not supposed to even exist but still</p>



<a name="187062314"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/do_docs_comments/near/187062314" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/do_docs_comments.html#187062314">(Jan 31 2020 at 07:33)</a>:</h4>
<p>I don't think we can just blacklist it recursively, because someone might name a crate <code>target</code></p>



<a name="187067310"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/do_docs_comments/near/187067310" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/do_docs_comments.html#187067310">(Jan 31 2020 at 09:16)</a>:</h4>
<p>I do think <code>if path.contains("target")</code> would be good enough</p>



<a name="187073563"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/do_docs_comments/near/187073563" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> divma <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/do_docs_comments.html#187073563">(Jan 31 2020 at 10:59)</a>:</h4>
<p>new mini issue then?</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>